According to Wm Safire, the term yellow-dog Democrat was originally a positive term coined by Democrats during the Hoover-Smith election in 1928. Reminds me of politically correct, which I first heard being used as a critical label for uncritcally thinking leftest, got appropriated by the right.