O.K., I'm just telling you what the expression would mean here, not my opinion, don't be harping on the messenger...

Only old men wear white shoes (we're not talking running shoes here.) So a white-show lawyer or white-shoe accountant would be an old lawyer or accountant.

You can be a senior partner without being old, so adding the white-shoe reference says that the man is old.