Jo, we would tend to call those things built-in bookcases, or wall units, as opposed to cupboards.

Here also, cupboards are used for storing food in the kitchen. In French we use a "Frenchified" version of pantry to mean the same thing. The government is trying to make us say armoire instead.

We definitely put clothes in a closet (a garderobe/dress minder in French).